fix(sdk): use correct controller during stream creation#724
Merged
Conversation
stbrody
approved these changes
Jun 23, 2025
| /** The model's stream ID */ | ||
| model: StreamID | ||
| /** The controller of the stream (DID string or literal string) */ | ||
| controller: DIDString | string |
Collaborator
There was a problem hiding this comment.
this is losing the ability for the user to set the controller DID string explicitly, but maybe that's fine? Almost everyone is going to be using did-session anyway so maybe that doesn't really matter as a feature
Contributor
Author
There was a problem hiding this comment.
Yeah, I think that should be ok.
I could have left the DID strings in but that would have meant leaving it to callers to check whether the DID had a parent PKH and then to pass that in, which felt risky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @m0ar
Closes #725